Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare NonStop for fixed-size integer types. #18325

Closed
wants to merge 1 commit into from
Closed

Prepare NonStop for fixed-size integer types. #18325

wants to merge 1 commit into from

Conversation

rsbeckerca
Copy link
Contributor

@rsbeckerca rsbeckerca commented May 16, 2022 •
edited

This commit removes platform defines the interfere with loading and resolution
of platform and memory model variants of integer types and includes the
appropriate files, stdint.h and sys/types.h where the types are defined.

Fixes #17669

Signed-off-by: Randall S. Becker <randall.becker@nexbridge.ca

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: feature The issue/pr requests/adds a feature labels May 16, 2022
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label May 16, 2022
@rsbeckerca
Copy link
Contributor Author

Re-pushed with suggestions from @mattcaswell

mattcaswell
mattcaswell approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulidale - still ok?

@mattcaswell
Copy link
Member

I wonder why github thinks you are a "first time contributor"?

@rsbeckerca
Copy link
Contributor Author

I wonder why github thinks you are a "first time contributor"?

It might be the email. I can re-push with a different one... hang on.

@rsbeckerca
Prepare NonStop for fixed-size integer types.
b7bb679 
This commit removes platform defines the interfere with loading and resolution
of platform and memory model variants of integer types and includes the
appropriate files, stdint.h and sys/types.h where the types are defined.

Fixes openssl#17669

Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
@rsbeckerca
Copy link
Contributor Author

I wonder why github thinks you are a "first time contributor"?

It might be the email. I can re-push with a different one... hang on.

Try now.

@mattcaswell
Copy link
Member

Try now.

Still showing you as a first time contributor. It's no big deal - it just means we have to manually approve the GitHub CI runs.

@mattcaswell
Copy link
Member

Ah...did you change your github id? This page shows you as @rsbecker

https://github.com/openssl/openssl/graphs/contributors

@rsbeckerca
Copy link
Contributor Author

Ah...did you change your github id? This page shows you as @rsbecker

https://github.com/openssl/openssl/graphs/contributors

That's weird. I have not used @rsbecker in a long time. Should I go back to the randall.becker@nexbridge.ca email?

@mattcaswell
Copy link
Member

That's weird. I have not used @rsbecker in a long time. Should I go back to the randall.becker@nexbridge.ca email?

Use whichever email you think is most appropriate.

@rsbeckerca
Copy link
Contributor Author

Let's just keep it as is. I can't chase GitHub's database ;)

@rsbeckerca
Copy link
Contributor Author

FYI: I had to provide two distinct contributor permission things to OpenSSL for each email.

@rsbeckerca
Copy link
Contributor Author

@mattcaswell Have a look now. I merged the account emails.

@paulidale
Copy link
Contributor

Still good.

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 18, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels May 19, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor

Merged, thanks.

@paulidale paulidale closed this May 19, 2022
openssl-machine pushed a commit that referenced this pull request May 19, 2022
@rsbeckerca @paulidale
Prepare NonStop for fixed-size integer types.
ec26144 
This commit removes platform defines the interfere with loading and resolution
of platform and memory model variants of integer types and includes the
appropriate files, stdint.h and sys/types.h where the types are defined.

Fixes #17669

Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #18325)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 14, 2022
@rsbeckerca @t8m
Prepare NonStop for fixed-size integer types.
226c4c7 
This commit removes platform defines the interfere with loading and resolution
of platform and memory model variants of integer types and includes the
appropriate files, stdint.h and sys/types.h where the types are defined.

Fixes openssl#17669

Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#18325)

(cherry picked from commit ec26144)
openssl-machine pushed a commit that referenced this pull request Nov 21, 2022
@rsbeckerca @t8m
Prepare NonStop for fixed-size integer types.
1aadae9 
This commit removes platform defines the interfere with loading and resolution
of platform and memory model variants of integer types and includes the
appropriate files, stdint.h and sys/types.h where the types are defined.

Fixes #17669

Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #18325)

(cherry picked from commit ec26144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch severity: fips change The pull request changes FIPS provider sources triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rsbeckerca @mattcaswell @paulidale @openssl-machine @levitte