High level overview of QUIC Implementation #18406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t8m
added
branch: master
paulidale
reviewed
May 26, 2022
There was a problem hiding this comment.
It isn't entirely obvious which way some of the arrows in the diagram at going. Some separation of the end points of multiple lines would be used here.
e.g. the "TLS Handshake Record Layer" is great, "Path and Conn Demux" is difficult. It isn't possible to tell if it is a one way or two way arrow between "Timer and Event Queue" and "ACK Handling and Loss Detector"?
Done. |
paulidale
approved these changes
Jun 7, 2022
t8m
added
hold: need otc decision
|
Should OTC approve this (at least by consensus?) |
beldmit
added
approval: done
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
|
OTC approved it by consensus on the last meeting. Merged to master branch. Thank you for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 8, 2022
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #18406)
sftcd
pushed a commit
to sftcd/openssl
that referenced
this pull request
Sep 24, 2022
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl#18406)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a high level overview of OpenSSL QUIC Implementation building blocks.
Checklist