Fix compiling in directories with spaces #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix helps especially building OpenSSL on Windows when using Jenkins as the default build directory contains spaces in its pathname. This patch requires the bsd_glob functions of Perl to be available which usually should be the case for any reasonable Perl configuration.
|
@levitte you want to look at this? |
| @@ -1,7 +1,7 @@ | |||
| #!/usr/local/bin/perl | |||
|
|
|||
| use Fcntl; | |||
|
|
|||
| use File::Glob ':glob'; | |||
There was a problem hiding this comment.
According to my manual, :glob is discouraged. Please use :bsd_glob
|
+1 |
|
The build system has been entirely rebuilt Therefore, this PR doesn't make sense any more. Closing. |
mcr
pushed a commit
to mcr/openssl
that referenced
this pull request
Jun 22, 2021
Correctly verify abbreviated IPv6 SANs
mamckee
pushed a commit
to mamckee/openssl
that referenced
this pull request
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix helps especially building OpenSSL on Windows when using Jenkins as the default build directory contains spaces in its pathname.
This patch requires the bsd_glob functions of Perl to be available which usually should be the case for any reasonable Perl configuration.