Add OSSL_CMP_CTX_get0_validatedSrvCert()
#18656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDvO
added
branch: master
t8m
requested changes
Jun 27, 2022
|
@t8m, your comments have been addressed. |
DDvO
force-pushed
the
add_OSSL_CMP_CTX_get0_validatedSrvCert
branch
from
dc1c84b
to
27c2aeb
Compare
|
Rebased to solve trivial merge conflict. Also here reviewing can continue. |
beldmit
approved these changes
Jul 17, 2022
DDvO
removed
the
approval: otc review pending
|
@t8m, since you gave comments on PR before, which have been addressed, can you approve, too? |
t8m
approved these changes
Jul 18, 2022
|
@beldmit still OK? |
…e_msg() Also change ossl_cmp_ctx_set0_validatedSrvCert() to ossl_cmp_ctx_set1_validatedSrvCert(), and add respective tests as well as the -srvcertout CLI option using the new function.
DDvO
force-pushed
the
add_OSSL_CMP_CTX_get0_validatedSrvCert
branch
from
cb5a304
to
fef2a1b
Compare
t8m
approved these changes
Jul 19, 2022
beldmit
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 20, 2022
…e_msg() Also change ossl_cmp_ctx_set0_validatedSrvCert() to ossl_cmp_ctx_set1_validatedSrvCert(), and add respective tests as well as the -srvcertout CLI option using the new function. Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from #18656)
DDvO
added a commit
to mpeylo/cmpossl
that referenced
this pull request
Aug 5, 2022
…e_msg() Also change ossl_cmp_ctx_set0_validatedSrvCert() to ossl_cmp_ctx_set1_validatedSrvCert(), and add respective tests as well as the -srvcertout CLI option using the new function. Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from openssl#18656)
sftcd
pushed a commit
to sftcd/openssl
that referenced
this pull request
Sep 24, 2022
…e_msg() Also change ossl_cmp_ctx_set0_validatedSrvCert() to ossl_cmp_ctx_set1_validatedSrvCert(), and add respective tests as well as the -srvcertout CLI option using the new function. Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from openssl#18656)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSSL_CMP_CTX_get0_validatedSrvCert()OSSL_CMP_validate_msg()ossl_cmp_ctx_set0_validatedSrvCert()toossl_cmp_ctx_set1_validatedSrvCert()-srvcertoutCLI option using the new function.