Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes memory leak in X509V3_add1_i2d #18698

Closed
wants to merge 1 commit into from
Closed

Fixes memory leak in X509V3_add1_i2d #18698

wants to merge 1 commit into from

Conversation

allanchang96
Copy link
Contributor

@allanchang96 allanchang96 commented Jul 1, 2022 •
edited

Fixes #18677

t8m
t8m reviewed Jul 7, 2022
View reviewed changes
crypto/x509/v3_lib.c Outdated Show resolved Hide resolved
@t8m t8m added branch: master Merge to master branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug labels Jul 7, 2022
@allanchang96 allanchang96 force-pushed the #18677 branch 2 times, most recently from 1c75d42 to 1dc9460 Compare July 7, 2022 23:04
@allanchang96
Fixes memory leak in X509V3_add1_i2d
5f18b05 
when flag is X509V3_ADD_DELETE
Issue openssl#18677
@t8m t8m added the approval: review pending This pull request needs review by a committer label Jul 8, 2022
@hlandau hlandau added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jul 8, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jul 9, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Jul 11, 2022
@allanchang96 @t8m
Fix memory leak in X509V3_add1_i2d when flag is X509V3_ADD_DELETE
c3efe5c 
Fixes #18677

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #18698)

(cherry picked from commit 4798e06)
openssl-machine pushed a commit that referenced this pull request Jul 11, 2022
@allanchang96 @t8m
Fix memory leak in X509V3_add1_i2d when flag is X509V3_ADD_DELETE
c340dfa 
Fixes #18677

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #18698)

(cherry picked from commit 4798e06)
openssl-machine pushed a commit that referenced this pull request Jul 11, 2022
@allanchang96 @t8m
Fix memory leak in X509V3_add1_i2d when flag is X509V3_ADD_DELETE
4798e06 
Fixes #18677

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #18698)
@hlandau
Copy link
Member

hlandau commented Jul 12, 2022

Closing as I believe this has been merged. Thank you.

@hlandau hlandau closed this Jul 12, 2022
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this pull request Sep 9, 2022
@allanchang96 @bernd-edlinger
Fix memory leak in X509V3_add1_i2d when flag is X509V3_ADD_DELETE
ac6ccc7 
Fixes openssl#18677

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#18698)

(cherry picked from commit 4798e06)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this pull request Sep 9, 2022
@allanchang96 @bernd-edlinger
Fix memory leak in X509V3_add1_i2d when flag is X509V3_ADD_DELETE
b2d2c54 
Fixes openssl#18677

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#18698)

(cherry picked from commit 4798e06)
bernd-edlinger pushed a commit to bernd-edlinger/openssl that referenced this pull request Sep 9, 2022
@allanchang96 @bernd-edlinger
Fix memory leak in X509V3_add1_i2d when flag is X509V3_ADD_DELETE
4957a96 
Fixes openssl#18677

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#18698)

(cherry picked from commit 4798e06)
sftcd pushed a commit to sftcd/openssl that referenced this pull request Sep 24, 2022
@allanchang96 @sftcd
Fix memory leak in X509V3_add1_i2d when flag is X509V3_ADD_DELETE
afc1c27 
Fixes openssl#18677

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#18698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlandau hlandau hlandau approved these changes

@t8m t8m t8m approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory Leak in X509V3_add1_i2d when flag is X509V3_ADD_DELETE
4 participants
@allanchang96 @openssl-machine @hlandau @t8m