Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEWS.md: Drop an extra empty line causing mdlint failure #18740

Closed
wants to merge 1 commit into from
Closed

NEWS.md: Drop an extra empty line causing mdlint failure #18740

wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Jul 7, 2022

This extra line causes CI failure on the 3.0 branch.

Checklist
  • documentation is added or updated

@t8m t8m added approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: documentation The issue/pr deals with documentation (errors) branch: 3.0 Merge to openssl-3.0 branch labels Jul 7, 2022
@hlandau hlandau removed the approval: review pending This pull request needs review by a committer label Jul 7, 2022
@levitte levitte added approval: done This pull request has the required number of approvals and removed approval: otc review pending This pull request needs review by an OTC member labels Jul 7, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jul 8, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member Author

t8m commented Jul 8, 2022

Merged to the 3.0 branch. Thank you for the reviews.

@t8m t8m closed this Jul 8, 2022
openssl-machine pushed a commit that referenced this pull request Jul 8, 2022
@t8m
NEWS.md: Drop an extra empty line causing mdlint failure
197e6a3 
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from #18740)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@hlandau hlandau hlandau approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: 3.0 Merge to openssl-3.0 branch triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@t8m @openssl-machine @levitte @hlandau @paulidale