Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speed: Always reset the outlen when calling EVP_PKEY_derive #18777

Closed
wants to merge 2 commits into from
Closed

speed: Always reset the outlen when calling EVP_PKEY_derive #18777

wants to merge 2 commits into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Jul 11, 2022

Fixes #18768

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch labels Jul 11, 2022
@t8m t8m mentioned this pull request Jul 11, 2022
Closed
paulidale
paulidale approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit in a comment :)

apps/speed.c Outdated
int count;

for (count = 0; COND(ffdh_c[testnum][0]); count++)
for (count = 0; COND(ffdh_c[testnum][0]); count++) {
/* outlen can be overwritten with too small value (no padding used) */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too small a value.

@slontis slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member labels Jul 12, 2022
@slontis
Copy link
Member

slontis commented Jul 12, 2022

Approved still if the comment is updated

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@slontis slontis added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jul 13, 2022
@hlandau
Copy link
Member

hlandau commented Jul 13, 2022

Merged to master and 3.0. Thank you.

@hlandau hlandau closed this Jul 13, 2022
openssl-machine pushed a commit that referenced this pull request Jul 13, 2022
@t8m @hlandau
speed: Always reset the outlen when calling EVP_PKEY_derive
c060c04 
Fixes #18768

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from #18777)

(cherry picked from commit ab8d56d)
openssl-machine pushed a commit that referenced this pull request Jul 13, 2022
@t8m @hlandau
speed: Always reset the outlen when calling EVP_PKEY_derive
ab8d56d 
Fixes #18768

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from #18777)
sftcd pushed a commit to sftcd/openssl that referenced this pull request Sep 24, 2022
@t8m @sftcd
speed: Always reset the outlen when calling EVP_PKEY_derive
7b9b8b6 
Fixes openssl#18768

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from openssl#18777)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulidale paulidale paulidale approved these changes

@slontis slontis slontis approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openssl 3.0.3: error when running openssl speed ffdh
5 participants
@t8m @slontis @openssl-machine @hlandau @paulidale