Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bio_b64.c: improve coding style #18787

Closed
wants to merge 3 commits into from
Closed

bio_b64.c: improve coding style #18787

wants to merge 3 commits into from

Conversation

DDvO
Copy link
Contributor

@DDvO DDvO commented Jul 12, 2022

Carved out from #18783

@DDvO DDvO added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: refactor The issue/pr requests/implements refactoring labels Jul 12, 2022
t8m
t8m requested changes Jul 12, 2022
View reviewed changes
crypto/evp/bio_b64.c Outdated Show resolved Hide resolved
crypto/evp/bio_b64.c Outdated Show resolved Hide resolved
crypto/evp/bio_b64.c Outdated Show resolved Hide resolved
paulidale
paulidale reviewed Jul 13, 2022
View reviewed changes
crypto/evp/bio_b64.c Outdated Show resolved Hide resolved
@paulidale paulidale removed the approval: review pending This pull request needs review by a committer label Jul 13, 2022
@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: otc review pending This pull request needs review by an OTC member labels Jul 13, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jul 14, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@hlandau
Copy link
Member

hlandau commented Jul 14, 2022 •
edited

Merged to master. Thank you.

@hlandau hlandau closed this Jul 14, 2022
openssl-machine pushed a commit that referenced this pull request Jul 14, 2022
@DDvO @hlandau
crypto/evp/bio_b64.c: improve coding style
f95fec2 
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #18787)
sftcd pushed a commit to sftcd/openssl that referenced this pull request Sep 24, 2022
@DDvO @sftcd
crypto/evp/bio_b64.c: improve coding style
1f2779f 
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#18787)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlandau hlandau hlandau approved these changes

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch triaged: refactor The issue/pr requests/implements refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DDvO @openssl-machine @hlandau @t8m @paulidale