Fix aarch64 signed bit shift issue found by UBSAN #18816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix conditional branch out of range when using sanitisers. Fixes openssl#18813 Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com> Change-Id: Ic543885091ed3ef2ddcbe21de0a4ac0bca1e2494
t8m
approved these changes
Jul 18, 2022
t8m
added
branch: master
github-actions
bot
added
the
severity: fips change
mattcaswell
approved these changes
Jul 18, 2022
mattcaswell
added
approval: done
paulidale
approved these changes
Jul 19, 2022
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Jul 19, 2022
Also fix conditional branch out of range when using sanitisers. Fixes #18813 Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com> Change-Id: Ic543885091ed3ef2ddcbe21de0a4ac0bca1e2494 Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #18816)
|
Merged to master branch. And the header fix cherry-picked to 3.0 branch too. The crypto/aes/asm/bsaes-armv8.pl is not present in 3.0 so that part of the patch was skipped. |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 19, 2022
Fixes #18813 Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com> Change-Id: Ic543885091ed3ef2ddcbe21de0a4ac0bca1e2494 Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #18816) (cherry picked from commit 1efd853)
|
@t8m @mattcaswell @paulidale In the discussion about the problems with OpenSSL v3.0.3 on Tandem NonStop (#18232) , Matt Caswell asked about them adding a buildbot worker to the OpenSSL project CI. Is there something we can do like this to add native (rather than cross-compiled) What's the best way to progress this? |
sftcd
pushed a commit
to sftcd/openssl
that referenced
this pull request
Sep 24, 2022
Also fix conditional branch out of range when using sanitisers. Fixes openssl#18813 Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com> Change-Id: Ic543885091ed3ef2ddcbe21de0a4ac0bca1e2494 Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#18816)
OttoHollmann
added a commit
to OttoHollmann/openssl
that referenced
this pull request
Mar 10, 2023
Also fix conditional branch out of range when using sanitisers. Fixes openssl#18813 Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com> Change-Id: Ic543885091ed3ef2ddcbe21de0a4ac0bca1e2494 Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#18816)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix conditional branch out of range when using sanitisers.
Fixes #18813