New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix three coverity issues #18822
Closed
Closed
Fix three coverity issues #18822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The earlier fix being inadequate
paulidale
added
branch: master
Merge to master branch
approval: review pending
This pull request needs review by a committer
approval: otc review pending
This pull request needs review by an OTC member
branch: 3.0
Merge to openssl-3.0 branch
labels
Jul 19, 2022
github-actions
bot
added
the
severity: fips change
The pull request changes FIPS provider sources
label
Jul 19, 2022
beldmit
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
beldmit
removed
the
approval: otc review pending
This pull request needs review by an OTC member
label
Jul 19, 2022
t8m
reviewed
Jul 19, 2022
t8m
approved these changes
Jul 19, 2022
t8m
added
approval: done
This pull request has the required number of approvals
and removed
approval: review pending
This pull request needs review by a committer
labels
Jul 19, 2022
t8m
approved these changes
Jul 19, 2022
Merged, thanks for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 20, 2022
The earlier fix being inadequate Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #18822)
openssl-machine
pushed a commit
that referenced
this pull request
Jul 20, 2022
Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #18822)
sftcd
pushed a commit
to sftcd/openssl
that referenced
this pull request
Sep 24, 2022
The earlier fix being inadequate Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from openssl#18822)
sftcd
pushed a commit
to sftcd/openssl
that referenced
this pull request
Sep 24, 2022
Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from openssl#18822)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approval: done
This pull request has the required number of approvals
branch: master
Merge to master branch
branch: 3.0
Merge to openssl-3.0 branch
severity: fips change
The pull request changes FIPS provider sources
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing Coverity issues 1507372, 1503321 & 1503327.