Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test from "Fix re-signing certificates with different key sizes" (master) #18841

Closed
wants to merge 1 commit into from
Closed

Add test from "Fix re-signing certificates with different key sizes" (master) #18841

wants to merge 1 commit into from

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jul 21, 2022

Tests for #16080 and #18836

Checklist
  • documentation is added or updated
  • tests are added or updated

@tmshort tmshort added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug labels Jul 21, 2022
@tmshort tmshort requested review from t8m and mattcaswell July 21, 2022 16:13
@tmshort tmshort mentioned this pull request Jul 21, 2022
Closed
2 tasks
@tmshort tmshort changed the title Add test from "Fix re-signing certificates with different key sizes" Add test from "Fix re-signing certificates with different key sizes" (master) Jul 21, 2022
@tmshort tmshort self-assigned this Jul 21, 2022
@t8m
Copy link
Member

t8m commented Jul 21, 2022

Approved assuming CI passes.

@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Jul 21, 2022
@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jul 21, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jul 22, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@tmshort
Copy link
Contributor Author

tmshort commented Jul 22, 2022

Merged to master

@tmshort tmshort closed this Jul 22, 2022
@tmshort tmshort deleted the fix-certs-master branch July 22, 2022 17:52
openssl-machine pushed a commit that referenced this pull request Jul 22, 2022
@tmshort
Add test from "Fix re-signing certificates with different key sizes"
29fcd2e 
Tests for #16080 and #18836

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #18841)
sftcd pushed a commit to sftcd/openssl that referenced this pull request Sep 24, 2022
@tmshort @sftcd
Add test from "Fix re-signing certificates with different key sizes"
9248f11 
Tests for openssl#16080 and openssl#18836

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#18841)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees

@tmshort tmshort

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tmshort @t8m @openssl-machine @mattcaswell