Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segfault occurrence in PEM_write() #18865

Closed
wants to merge 2 commits into from
Closed

Fix segfault occurrence in PEM_write() #18865

wants to merge 2 commits into from

Conversation

valdaarhun
Copy link
Contributor

Fixes #18825
Checks if header is NULL or not before calling strlen().

CLA: trivial

Checklist
  • documentation is added or updated
  • tests are added or updated

@valdaarhun
Fixes #18825 (fixes segfault occurrence in PEM_write())
82435b6 
Checks if header is NULL or not before calling strlen().

CLA: trivial
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug cla: trivial One of the commits is marked as 'CLA: trivial' branch: 3.0 Merge to openssl-3.0 branch labels Jul 25, 2022
t8m
t8m requested changes Jul 25, 2022
View reviewed changes
crypto/pem/pem_lib.c Outdated Show resolved Hide resolved
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Jul 25, 2022
@t8m
Copy link
Member

t8m commented Jul 25, 2022

OK with CLA: trivial

@kaduk kaduk added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jul 28, 2022
@kaduk
Copy link
Contributor

kaduk commented Jul 28, 2022

OK with CLA: trivial

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@paulidale
Copy link
Contributor

Merged, thanks for the fix.

@paulidale paulidale closed this Jul 29, 2022
openssl-machine pushed a commit that referenced this pull request Jul 29, 2022
@valdaarhun @paulidale
Fixes segfault occurrence in PEM_write()
6834807 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #18865)

(cherry picked from commit 2059574)
openssl-machine pushed a commit that referenced this pull request Jul 29, 2022
@valdaarhun @paulidale
Fixes segfault occurrence in PEM_write()
2059574 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #18865)
openssl-machine pushed a commit that referenced this pull request Jul 29, 2022
@valdaarhun @paulidale
Fixes segfault occurrence in PEM_write()
3b9082c 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #18865)

(cherry picked from commit 2059574)
@valdaarhun
Copy link
Contributor Author

Thank you for the reviews. This was my first contribution and I hope to contribute further in the future.

@valdaarhun valdaarhun deleted the fix_PEM_write_segfault branch July 29, 2022 05:47
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Jul 31, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
c927378 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Jul 31, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
8dadf43 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Jul 31, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
51997f7 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Jul 31, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
b238b9c 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Aug 3, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
512ce4c 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Aug 3, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
e0312ab 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Aug 3, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
60abffb 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Aug 5, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
7972416 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Aug 5, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
9e97529 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Aug 5, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
853d033 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Aug 5, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
9d6b7c4 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Aug 5, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
a76b68e 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Aug 5, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
a5cacf0 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Aug 5, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
99f6e97 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Aug 5, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
086d9d4 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Aug 5, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
510b53f 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Aug 5, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
9b3468c 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Aug 5, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
772aeaf 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
JeffroMF pushed a commit to JeffroMF/openssl.1.55555 that referenced this pull request Aug 5, 2022
@valdaarhun @JeffroMF
Fixes segfault occurrence in PEM_write()
7382268 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes #18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#18865)
sftcd pushed a commit to sftcd/openssl that referenced this pull request Sep 24, 2022
@valdaarhun @sftcd
Fixes segfault occurrence in PEM_write()
0c7cca3 
Checks if header is NULL or not before calling strlen().

CLA: trivial

Fixes openssl#18825

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#18865)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaduk kaduk kaduk approved these changes

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch branch: 3.0 Merge to openssl-3.0 branch cla: trivial One of the commits is marked as 'CLA: trivial' triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PEM_write() causes segfault with header=NULL
5 participants
@valdaarhun @t8m @kaduk @openssl-machine @paulidale