Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BSD-armv4 target based on linux-armv4 #18910

Closed
wants to merge 1 commit into from
Closed

Add BSD-armv4 target based on linux-armv4 #18910

wants to merge 1 commit into from

Conversation

pkubaj
Copy link
Contributor

@pkubaj pkubaj commented Jul 29, 2022

If possible, please also merge to 1.1.1 and 3.0.

Checklist
  • documentation is added or updated
  • tests are added or updated

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Jul 29, 2022
@hlandau
Copy link
Member

hlandau commented Aug 1, 2022

Thank you. You will need to sign a CLA:

https://www.openssl.org/policies/cla.html

@pkubaj
Copy link
Contributor Author

pkubaj commented Aug 1, 2022

Again? I have already signed one for #17090

@t8m
Copy link
Member

t8m commented Aug 1, 2022

Perhaps a different e-mail address was used for this commit?

@mattcaswell
Copy link
Member

Perhaps a different e-mail address was used for this commit?

That is the case. #17090 uses your FreeBSD email address. This PR is using an email address that wasn't mentioned in your original ICLA. Is your contribution here on behalf of your employer? If so you will additionally need to be listed in the Intel CCLA. If your contribution is personal can you update the author to match that given in your ICLA?

@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Aug 1, 2022
@pkubaj
Copy link
Contributor Author

pkubaj commented Aug 1, 2022

No, that was a mistake. It wasn't related to my work. Updated.

mattcaswell
mattcaswell approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you are ok with being named as the nominated community member for this platform on the platform policy (as you already are for other platforms)? If so please can you raise a PR to add yourself?

As to backport to 3.0/1.1.1 they are both LTS releases, and our policy says "The addition of new platforms to LTS branches is acceptable so long as the required changes consist solely of additions to configuration.". So, the changes in Configurations/10-main.conf would be acceptable - but the changes in util/perl/OpenSSL/config.pm are technically code not configuration. A version of this PR that doesn't make those changes would be ok for 3.0/1.1.1

@mattcaswell mattcaswell added branch: master Merge to master branch approval: review pending This pull request needs review by a committer branch: 3.0 Merge to openssl-3.0 branch and removed branch: 3.0 Merge to openssl-3.0 branch labels Aug 2, 2022
tmshort
tmshort reviewed Aug 3, 2022
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be an inherit_from statement somewhere? e.g.

    inherit_from => [ "BSD-generic64"],

@pkubaj
Copy link
Contributor Author

pkubaj commented Aug 3, 2022

Indeed there should, thanks for catching that.

mattcaswell
mattcaswell approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reconfirm

@hlandau hlandau added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Aug 4, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Aug 5, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@mattcaswell mattcaswell added the hold: need omc decision The OMC needs to make a decision label Aug 10, 2022
@mattcaswell
Copy link
Member

I've applied a temporary hold to this until openssl/web#357 is merged. Once that's in, this one can go in too.

@tmshort
Copy link
Contributor

tmshort commented Aug 19, 2022

Is this one ready, as openssl/web#357 has been merged?

@paulidale paulidale removed the hold: need omc decision The OMC needs to make a decision label Aug 22, 2022
@t8m t8m added the triaged: feature The issue/pr requests/adds a feature label Aug 22, 2022
@t8m
Copy link
Member

t8m commented Aug 22, 2022

Merged to master branch. Thank you for your contribution.

@t8m t8m closed this Aug 22, 2022
openssl-machine pushed a commit that referenced this pull request Aug 22, 2022
@pkubaj @t8m
Add BSD-armv4 target based on linux-armv4
a9389c0 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #18910)
sftcd pushed a commit to sftcd/openssl that referenced this pull request Sep 24, 2022
@pkubaj @sftcd
Add BSD-armv4 target based on linux-armv4
a8a38b6 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#18910)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 21, 2022
@pkubaj @t8m
Add BSD-armv4 target based on linux-armv4
08e9ff9 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#18910)

(cherry picked from commit a9389c0)
openssl-machine pushed a commit that referenced this pull request Nov 23, 2022
@pkubaj @t8m
Add BSD-armv4 target based on linux-armv4
38186a2 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #18910)

(cherry picked from commit a9389c0)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@pkubaj @beldmit
Add BSD-armv4 target based on linux-armv4
adecaf7 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#18910)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlandau hlandau hlandau approved these changes

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@tmshort tmshort tmshort approved these changes

@hussain2022a hussain2022a hussain2022a approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pkubaj @hlandau @t8m @mattcaswell @openssl-machine @tmshort @hussain2022a @paulidale