Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some documentation for X509_gmtime_adj() #18974

Closed
wants to merge 2 commits into from

Conversation

mattcaswell
Copy link
Member

Other very similar functions were documented, but this one was missing.

Other very similar functions were documented, but this one was missing.
@mattcaswell mattcaswell added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member labels Aug 10, 2022
@hlandau hlandau removed the approval: review pending This pull request needs review by a committer label Aug 11, 2022
@t8m t8m added approval: done This pull request has the required number of approvals triaged: documentation The issue/pr deals with documentation (errors) and removed approval: otc review pending This pull request needs review by an OTC member labels Aug 16, 2022
@t8m
Copy link
Member

t8m commented Aug 16, 2022

If this cherry-picks cleanly, it should be merged to 3.0 as well.

@t8m t8m added the branch: 3.0 Merge to openssl-3.0 branch label Aug 16, 2022
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@paulidale paulidale added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Aug 17, 2022
@mattcaswell
Copy link
Member Author

Pushed to master and 3.0.

openssl-machine pushed a commit that referenced this pull request Aug 18, 2022
Other very similar functions were documented, but this one was missing.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #18974)
openssl-machine pushed a commit that referenced this pull request Aug 18, 2022
Other very similar functions were documented, but this one was missing.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #18974)

(cherry picked from commit 425e972)
sftcd pushed a commit to sftcd/openssl that referenced this pull request Sep 24, 2022
Other very similar functions were documented, but this one was missing.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#18974)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants