Replace the 'SSL' broken link in ciphers doc with one pointing to security levels explained #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levitte
requested changes
Nov 11, 2016
| @@ -717,7 +717,7 @@ Set security level to 2 and display all ciphers consistent with level 2: | |||
|
|
|||
| =head1 SEE ALSO | |||
|
|
|||
| L<s_client(1)>, L<s_server(1)>, L<ssl(3)> | |||
There was a problem hiding this comment.
Section 3 is wrong, it's in section 7 (have a look in doc/man7)
I think I would prefer if the section number was changed unless there's a strong reason to change the reference.
There was a problem hiding this comment.
You'r right. Sorry for missing that. May I still propose to add the link to 'security levels' which I found very usefull ?
PR changed.
There was a problem hiding this comment.
In such a case, is it better to modify the PR title ?
There was a problem hiding this comment.
i don't think ciphers is the place for the security-levels link. it should be in man7/ssl.
There was a problem hiding this comment.
OK, I am going to update the PR.
Done.
…eems not being referenced from elsewhere
richsalz
added
the
approval: done
levitte
pushed a commit
that referenced
this pull request
Nov 13, 2016
…eems not being referenced from elsewhere Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1898)
|
e330f55 on master; 66bf3bc on 1.1.0 thanks! |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSL_CTX_set_security_level() seems not being referenced from elsewhere and an example using SECLEVEL is provided just above the 'SEE ALSO' section