Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc-nits #19044

Closed
wants to merge 1 commit into from
Closed

Fix doc-nits #19044

wants to merge 1 commit into from

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Aug 22, 2022

PR #19031 updated options that that were listed as commands, these
options were already in openssl-list.pod.in, so they are redundant
in openssl.pod.

Checklist
  • documentation is added or updated
  • tests are added or updated

PR openssl#19031 updated options that that were listed as commands, these
options were already in openssl-list.pod.in, so they are redundant
in openssl.pod.
@tmshort tmshort added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: documentation The issue/pr deals with documentation (errors) severity: urgent Fixes an urgent issue (exempt from 24h grace period) labels Aug 22, 2022
@tmshort tmshort requested a review from levitte August 22, 2022 18:17
@tmshort
Copy link
Contributor Author

tmshort commented Aug 22, 2022

I put the "urgent" tag on as this fixes a CI/CD issue.
(Feel free to remove if it's not.)

@tmshort tmshort requested a review from t8m August 22, 2022 18:25
@tmshort tmshort added branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug labels Aug 22, 2022
@levitte levitte removed the approval: otc review pending This pull request needs review by an OTC member label Aug 22, 2022
@levitte
Copy link
Member

levitte commented Aug 22, 2022

I prefer this to #19031 (yeahok, it's merged now, but still) and #19038. After all, it makes little sense document the list subcommand twice (plus, the so called documentation in openssl(1) was incomplete, and possibly wrong too, so...)

@mattcaswell
Copy link
Member

Agree urgent

@mattcaswell
Copy link
Member

@levitte are you ok with urgent?

@paulidale
Copy link
Contributor

Agreed urgent and merged to both branches.

@paulidale paulidale closed this Aug 22, 2022
openssl-machine pushed a commit that referenced this pull request Aug 22, 2022
PR #19031 updated options that that were listed as commands, these
options were already in openssl-list.pod.in, so they are redundant
in openssl.pod.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19044)
openssl-machine pushed a commit that referenced this pull request Aug 22, 2022
PR #19031 updated options that that were listed as commands, these
options were already in openssl-list.pod.in, so they are redundant
in openssl.pod.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19044)

(cherry picked from commit a148f86)
sftcd pushed a commit to sftcd/openssl that referenced this pull request Sep 24, 2022
PR openssl#19031 updated options that that were listed as commands, these
options were already in openssl-list.pod.in, so they are redundant
in openssl.pod.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19044)
@tmshort tmshort deleted the fix-doc-nits branch December 7, 2022 14:03
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
PR openssl#19031 updated options that that were listed as commands, these
options were already in openssl-list.pod.in, so they are redundant
in openssl.pod.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: review pending This pull request needs review by a committer branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch severity: urgent Fixes an urgent issue (exempt from 24h grace period) triaged: bug The issue/pr is/fixes a bug triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants