Drop the optimisation level for ppc64le cross-compile #19056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default cross compiler (gcc 9.4.0) for ppc64le on Ubunut 20.04 seems buggy and causes a seg fault in sslapitest. This doesn't impact any other CI cross compile platforms and does not seem to impact the gcc 10.3.0 cross compiler. We just drop the optimisation level on that platform.
mattcaswell
added
branch: master
hlandau
approved these changes
Aug 24, 2022
hlandau
removed
the
approval: review pending
|
Approved subject to CI |
t8m
approved these changes
Aug 24, 2022
t8m
added
triaged: bug
|
As this is to fix the CI on-push breakage, IMO it is urgent. Do you agree @hlandau @mattcaswell? |
t8m
approved these changes
Aug 24, 2022
t8m
added
approval: done
|
Yes agreed urgent. The CI that fails only runs on push, not on a PR. However I have this running in my own personal fork here: https://github.com/mattcaswell/openssl/runs/7996920461?check_suite_focus=true I suggest waiting to push until that job is complete (and is green). |
|
Agreed urgent |
|
I'll leave this to @mattcaswell to merge. |
|
That build on my fork is green so - pushed. |
openssl-machine
pushed a commit
that referenced
this pull request
Aug 24, 2022
The default cross compiler (gcc 9.4.0) for ppc64le on Ubunut 20.04 seems buggy and causes a seg fault in sslapitest. This doesn't impact any other CI cross compile platforms and does not seem to impact the gcc 10.3.0 cross compiler. We just drop the optimisation level on that platform. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from #19056)
|
How confident are we that it is just the optimiser causing a problem rather than the optimiser exposing a bug? |
Well I can't be 100% sure, but it does not appear on any other platform and the problem goes away when using a later version of gcc (10.3.0). So my assumption is that this really is a compiler bug. |
sftcd
pushed a commit
to sftcd/openssl
that referenced
this pull request
Sep 24, 2022
The default cross compiler (gcc 9.4.0) for ppc64le on Ubunut 20.04 seems buggy and causes a seg fault in sslapitest. This doesn't impact any other CI cross compile platforms and does not seem to impact the gcc 10.3.0 cross compiler. We just drop the optimisation level on that platform. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from openssl#19056)
t8m
pushed a commit
to t8m/openssl
that referenced
this pull request
Nov 21, 2022
The default cross compiler (gcc 9.4.0) for ppc64le on Ubunut 20.04 seems buggy and causes a seg fault in sslapitest. This doesn't impact any other CI cross compile platforms and does not seem to impact the gcc 10.3.0 cross compiler. We just drop the optimisation level on that platform. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from openssl#19056) (cherry picked from commit 200d952)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 23, 2022
The default cross compiler (gcc 9.4.0) for ppc64le on Ubunut 20.04 seems buggy and causes a seg fault in sslapitest. This doesn't impact any other CI cross compile platforms and does not seem to impact the gcc 10.3.0 cross compiler. We just drop the optimisation level on that platform. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from #19056) (cherry picked from commit 200d952)
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
The default cross compiler (gcc 9.4.0) for ppc64le on Ubunut 20.04 seems buggy and causes a seg fault in sslapitest. This doesn't impact any other CI cross compile platforms and does not seem to impact the gcc 10.3.0 cross compiler. We just drop the optimisation level on that platform. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from openssl#19056)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default cross compiler (gcc 9.4.0) for ppc64le on Ubunut 20.04 seems
buggy and causes a seg fault in sslapitest. This doesn't impact any other
CI cross compile platforms and does not seem to impact the gcc 10.3.0 cross
compiler.
We just drop the optimisation level on that platform.