Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BIO_dgram_pair stochastic test failure #19268

Closed
wants to merge 1 commit into from
Closed

Fix BIO_dgram_pair stochastic test failure #19268

wants to merge 1 commit into from

Conversation

hlandau
Copy link
Member

@hlandau hlandau commented Sep 23, 2022

Fixes #19267.

@hlandau hlandau added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug labels Sep 23, 2022
@hlandau hlandau self-assigned this Sep 23, 2022
@hlandau hlandau mentioned this pull request Sep 23, 2022
Closed
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Sep 23, 2022
@mattcaswell
Copy link
Member

Is this causing CI test failures? Isn't this urgent?

@t8m
Copy link
Member

t8m commented Sep 23, 2022

I am OK with urgent.

@t8m t8m added severity: urgent Fixes an urgent issue (exempt from 24h grace period) approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 23, 2022
@mattcaswell
Copy link
Member

Me too.

@mattcaswell mattcaswell added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Sep 23, 2022
@hlandau
Copy link
Member Author

hlandau commented Sep 23, 2022

Agree urgent. Merging.

@hlandau
Copy link
Member Author

hlandau commented Sep 23, 2022

Merged to master.

@hlandau hlandau closed this Sep 23, 2022
openssl-machine pushed a commit that referenced this pull request Sep 23, 2022
@hlandau
Fix BIO_dgram_pair stochastic test failure
8e90a12 
Fixes #19267.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #19268)
sftcd pushed a commit to sftcd/openssl that referenced this pull request Sep 24, 2022
@hlandau @sftcd
Fix BIO_dgram_pair stochastic test failure
6990ff3 
Fixes openssl#19267.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl#19268)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@hlandau @beldmit
Fix BIO_dgram_pair stochastic test failure
71c7755 
Fixes openssl#19267.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl#19268)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@levitte levitte Awaiting requested review from levitte

Assignees

@hlandau hlandau

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period) triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BIO_dgram_pair test breakage, BIO_write with zero length writes
3 participants
@hlandau @mattcaswell @t8m