PKCS12_SAFEBAG_set0_attrs: Remove const from function signature #19359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcaswell
reviewed
Oct 7, 2022
crypto/pkcs12/p12_attr.c
Outdated
| @@ -125,5 +125,5 @@ void PKCS12_SAFEBAG_set0_attrs(PKCS12_SAFEBAG *bag, const STACK_OF(X509_ATTRIBUT | |||
| if (bag->attrib != attrs) | |||
| sk_X509_ATTRIBUTE_free(bag->attrib); | |||
|
|
|||
| bag->attrib = (STACK_OF(X509_ATTRIBUTE*))attrs; | |||
| bag->attrib = (STACK_OF(X509_ATTRIBUTE) *)attrs; | |||
There was a problem hiding this comment.
Hmmm. - this function doesn't quite look right. The cast is only necessary here because we are casting away the "const". But it probably should not be const at all, because we eventually plan to "free" this value. So I think the correct fix here is to remove the cast altogether and adjust the function signature to remove "const". This is ok because this function is newly added to master and doesn't exist in other branches - so backwards compatibility is not a concern.
faramir-dev
changed the title
mattcaswell
approved these changes
Oct 7, 2022
mattcaswell
added
branch: master
t8m
approved these changes
Oct 7, 2022
t8m
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to master. Thank you. |
openssl-machine
pushed a commit
that referenced
this pull request
Oct 13, 2022
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from #19359)
openssl-machine
pushed a commit
that referenced
this pull request
Oct 13, 2022
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from #19359)
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from openssl#19359)
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from openssl#19359)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist