eckey_priv_encode(): Call ASN1_STRING_free() only on an ASN1_STRING #19367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ASN1_OBJECT_free() never needs to be called on objects returned from OBJ_nid2obj(). Fixes openssl#19138
t8m
added
branch: master
paulidale
approved these changes
Oct 10, 2022
paulidale
removed
the
approval: otc review pending
beldmit
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to master and 3.0 branches. Thank you for the reviews. |
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
Also ASN1_OBJECT_free() never needs to be called on objects returned from OBJ_nid2obj(). Fixes openssl#19138 Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl#19367)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ASN1_OBJECT_free() never needs to be called on objects returned from OBJ_nid2obj().
Fixes #19138