Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGES.md and NEWS.md for new release (master) #19379

Closed
wants to merge 1 commit into from
Closed

Update CHANGES.md and NEWS.md for new release (master) #19379

wants to merge 1 commit into from

Conversation

mattcaswell
Copy link
Member

No description provided.

@mattcaswell mattcaswell added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member severity: urgent Fixes an urgent issue (exempt from 24h grace period) labels Oct 11, 2022
levitte
levitte approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@levitte levitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with acclamation!

@levitte levitte removed the approval: otc review pending This pull request needs review by an OTC member label Oct 11, 2022
@mattcaswell
Copy link
Member Author

Now with added "Release: yes" line in the commit

@levitte levitte added approval: done This pull request has the required number of approvals approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: review pending This pull request needs review by a committer labels Oct 11, 2022
@mattcaswell mattcaswell added approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member and removed approval: done This pull request has the required number of approvals approval: ready to merge The 24 hour grace period has passed, ready to merge severity: urgent Fixes an urgent issue (exempt from 24h grace period) labels Oct 11, 2022
@levitte levitte removed the approval: otc review pending This pull request needs review by an OTC member label Oct 11, 2022
@mattcaswell
Copy link
Member Author

Ummm...after further discussion with @levitte, I've removed the "Release: yes" again from this one since this is the master branch!!

@t8m t8m added approval: done This pull request has the required number of approvals triaged: documentation The issue/pr deals with documentation (errors) and removed approval: review pending This pull request needs review by a committer labels Oct 11, 2022
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@mattcaswell
Copy link
Member Author

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests.

No idea what the bot is on about. There are no failing tests. Applying the ready-to-merge label.

@mattcaswell mattcaswell added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 12, 2022
@mattcaswell
Copy link
Member Author

Pushed. Thanks.

openssl-machine pushed a commit that referenced this pull request Oct 12, 2022
@mattcaswell
Update CHANGES.md and NEWS.md for new release
79edcf4 
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19379)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@mattcaswell @beldmit
Update CHANGES.md and NEWS.md for new release
36baf58 
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#19379)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@t8m t8m t8m approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mattcaswell @openssl-machine @levitte @t8m