c_rehash: Fix file extension matching #19427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, parenthesis were added 8 years ago in commit a787c25. This essentially removed the \. and $ constructs from the middle branches. Hence a file called e.g. cert.key would accidentally match the (cer) rule. CLA: trivial
t8m
added
branch: master
t8m
removed
the
approval: otc review pending
paulidale
approved these changes
Oct 19, 2022
paulidale
added
approval: done
|
okay with trivial |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
|
Merged to master branch. In the end I've decided to not merge to 3.0 branch as in theory someone could depend on the existing match there and we do not want to introduce a break of such kind in existing stable release. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Oct 20, 2022
For some reason, parenthesis were added 8 years ago in commit a787c25. This essentially removed the \. and $ constructs from the middle branches. Hence a file called e.g. cert.key would accidentally match the (cer) rule. CLA: trivial Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #19427)
|
appreciated, thank you! |
t8m
pushed a commit
to t8m/openssl
that referenced
this pull request
Nov 21, 2022
For some reason, parenthesis were added 8 years ago in commit a787c25. This essentially removed the \. and $ constructs from the middle branches. Hence a file called e.g. cert.key would accidentally match the (cer) rule. CLA: trivial Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#19427) (cherry picked from commit 706fc5f)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 23, 2022
For some reason, parenthesis were added 8 years ago in commit a787c25. This essentially removed the \. and $ constructs from the middle branches. Hence a file called e.g. cert.key would accidentally match the (cer) rule. CLA: trivial Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #19427) (cherry picked from commit 706fc5f)
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
For some reason, parenthesis were added 8 years ago in commit a787c25. This essentially removed the \. and $ constructs from the middle branches. Hence a file called e.g. cert.key would accidentally match the (cer) rule. CLA: trivial Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#19427)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, parenthesis were added 8 years ago in commit a787c25. This essentially removed the . and $ constructs from the middle branches. Hence a file called e.g. cert.key would accidentally match the (cer) rule.
CLA: trivial