Potential null pointer reference #19429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
severity: fips change
|
The proper fix is IMO to fix the bug in the testcase. I.e., put the BN_CTX_start right after the BN_CTX_new() call. |
t8m
added
branch: master
Yes, I see the same approach for other test cases, but the unclear addition still has the same problem. And I'm going to do it as is customary. |
yangyangtiantianlonglong
force-pushed
the
bn_coredump
branch
from
417d3a2
to
8f7b400
Compare
github-actions
bot
removed
the
severity: fips change
paulidale
approved these changes
Oct 27, 2022
paulidale
added
the
approval: review pending
|
Please do not add merge commits. Use git rebase against fresh master branch instead. |
yangyangtiantianlonglong
force-pushed
the
bn_coredump
branch
from
cdb32e2
to
173e8db
Compare
Sorry, Git rebase has been redone. |
t8m
approved these changes
Oct 27, 2022
slontis
approved these changes
Oct 27, 2022
slontis
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to master, 3.0, and 3.1 branches. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 2, 2022
Reviewed-by: Shane Lontis <shane.lontis@oracle.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #19429)
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
Reviewed-by: Shane Lontis <shane.lontis@oracle.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#19429)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BN_CTX_end()-->BN_STACK_pop() may cause a null pointer reference.
Fixes #19428