Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coverity 1516101 deadcode #19464

Closed
wants to merge 1 commit into from
Closed

Fix coverity 1516101 deadcode #19464

wants to merge 1 commit into from

Conversation

faramir-dev
Copy link
Contributor

Checklist
  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer branch: 3.0 Merge to openssl-3.0 branch labels Oct 21, 2022
@t8m t8m added triaged: bug The issue/pr is/fixes a bug and removed branch: 3.0 Merge to openssl-3.0 branch labels Oct 21, 2022
@t8m
Copy link
Member

t8m commented Oct 21, 2022

This code is in master branch only.

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 21, 2022
@t8m t8m mentioned this pull request Oct 21, 2022
Closed
2 tasks
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@paulidale
Copy link
Contributor

Merged.

@paulidale paulidale closed this Oct 23, 2022
openssl-machine pushed a commit that referenced this pull request Oct 23, 2022
@faramir-dev @paulidale
Fix coverity 1516101 deadcode
7ccccb2 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19464)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@faramir-dev @beldmit
Fix coverity 1516101 deadcode
d4c6321 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19464)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@faramir-dev @t8m @openssl-machine @paulidale @mattcaswell