Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a lock in provider_remove_store_methods() #19481

Closed
wants to merge 1 commit into from
Closed

Fix a lock in provider_remove_store_methods() #19481

wants to merge 1 commit into from

Conversation

mattcaswell
Copy link
Member

We were taking a read lock. It should have been a write lock.

Fixes #19474

Checklist
  • documentation is added or updated
  • tests are added or updated

@mattcaswell
Fix a lock in provider_remove_store_methods()
e66cc35 
We were taking a read lock. It should have been a write lock.

Fixes openssl#19474
@mattcaswell mattcaswell added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member branch: 3.0 Merge to openssl-3.0 branch labels Oct 24, 2022
@mattcaswell mattcaswell mentioned this pull request Oct 24, 2022
Closed
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Oct 24, 2022
@t-j-h t-j-h removed the approval: otc review pending This pull request needs review by an OTC member label Oct 24, 2022
@hlandau hlandau added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 24, 2022
@t8m t8m added triaged: bug The issue/pr is/fixes a bug branch: 3.1 Merge to openssl-3.1 labels Oct 24, 2022
@mattcaswell mattcaswell added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 25, 2022
@mattcaswell
Copy link
Member Author

Pushed to master, 3.1 and 3.0.

openssl-machine pushed a commit that referenced this pull request Oct 25, 2022
@mattcaswell
Fix a lock in provider_remove_store_methods()
6962e21 
We were taking a read lock. It should have been a write lock.

Fixes #19474

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19481)
openssl-machine pushed a commit that referenced this pull request Oct 25, 2022
@mattcaswell
Fix a lock in provider_remove_store_methods()
02be04e 
We were taking a read lock. It should have been a write lock.

Fixes #19474

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19481)

(cherry picked from commit 6962e21)
openssl-machine pushed a commit that referenced this pull request Oct 25, 2022
@mattcaswell
Fix a lock in provider_remove_store_methods()
9cbd2e1 
We were taking a read lock. It should have been a write lock.

Fixes #19474

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19481)

(cherry picked from commit 6962e21)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@mattcaswell @beldmit
Fix a lock in provider_remove_store_methods()
5eb5f0b 
We were taking a read lock. It should have been a write lock.

Fixes openssl#19474

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19481)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlandau hlandau hlandau approved these changes

@t-j-h t-j-h t-j-h approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 severity: fips change The pull request changes FIPS provider sources triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should lock in provider_remove_store_methods be a write lock?
5 participants
@mattcaswell @hlandau @t-j-h @paulidale @t8m