Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP_expand_block: spelling (algorithm) #19509

Closed
wants to merge 3 commits into from
Closed

COMP_expand_block: spelling (algorithm) #19509

wants to merge 3 commits into from

Conversation

SergeCroise
Copy link
Contributor

@SergeCroise SergeCroise commented Oct 26, 2022 •
edited

CLA: trivial

Checklist
  • documentation is added or updated
  • tests are added or updated

paulidale
paulidale approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with trivial

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer cla: trivial One of the commits is marked as 'CLA: trivial' branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 triaged: documentation The issue/pr deals with documentation (errors) labels Oct 27, 2022
mattcaswell
mattcaswell approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree trivial

@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 27, 2022
@t8m t8m removed branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 labels Oct 27, 2022
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@SergeCroise
Copy link
Contributor Author

SergeCroise commented Oct 30, 2022 •
edited

what is the remaining failing check?
is this the reason for not merging automatically?
see also:
https://ci.buildbot.openssl.org/#/builders/46/builds/248

@mattcaswell mattcaswell added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 31, 2022
@mattcaswell
Copy link
Member

Looks like you pushed a new merge commit into this - after this was approved. Merge commits are not allowed and it will be dropped when we push this to the repo. This is ready-to-merge but the repo is currently frozen due to the release tomorrow, so it won't be merged until after that.

@hlandau
Copy link
Member

hlandau commented Nov 14, 2022

Merged to master. Thank you.

@hlandau hlandau closed this Nov 14, 2022
openssl-machine pushed a commit that referenced this pull request Nov 14, 2022
@SergeCroise @hlandau
COMP_expand_block: spelling (algorithm)
aa197f3 
CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from #19509)
@SergeCroise SergeCroise deleted the patch-2022-10-27 branch November 14, 2022 09:24
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@SergeCroise @beldmit
COMP_expand_block: spelling (algorithm)
0e3d009 
CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from openssl#19509)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial' triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SergeCroise @openssl-machine @mattcaswell @hlandau @paulidale @t8m