Try to fix CI sctp test. #19511
Try to fix CI sctp test. #19511
Conversation
|
This is a test -(mainly for my own sanity) |
|
@paulidale - this verifies what we saw before.. i.e. it works here... Maybe that means the infrastructure is different for the daily build? |
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get -yq install lksctp-tools libsctp-dev | ||
| checksctp |
There was a problem hiding this comment.
This should be enough and get rid of the OK environment variable:
- name: Check SCTP is available
run: checksctpThere was a problem hiding this comment.
Except for when it fails again on merge and I have to spend another day looking at it :)
There was a problem hiding this comment.
Yeah, that. This step will fail if checksctp does and the rest won't run. It avoid the conditionals.
There was a problem hiding this comment.
We might have to try this out by merging..
|
|
||
| - name: make test | ||
| run: make test HARNESS_JOBS=${HARNESS_JOBS:-4} | ||
| if: $OK == 0 |
There was a problem hiding this comment.
New line at end of file.
slontis
force-pushed
the
sctp_ci_attempt2
branch
2 times, most recently
from
333ac71
to
24700b8
Compare
|
@paulidale - just entered something bad to test it out.. That skips the tests and marks it as green |
|
What I am trying to do here is skip doing the tests if sctp cant be setup, and report a green result.. |
For some reason the newly introduced CI test for sctp causes issues. It is unknown why this seems to work when testing, but doesnt work once it was merged. The test has been put into its own file, with skips on error if the setup fails.. This will need to be merged to test if this works.
slontis
force-pushed
the
sctp_ci_attempt2
branch
from
02776fe
to
c1272cd
Compare
t8m
added
branch: master
paulidale
added
approval: review pending
|
ping |
t8m
added
approval: ready to merge
|
Merging as this is CI failure fix. |
|
Merged to master branch. Thank you. |
For some reason the newly introduced CI test for sctp causes issues. It is unknown why this seems to work when testing, but doesnt work once it was merged. The test has been put into its own file, with skips on error if the setup fails.. This will need to be merged to test if this works. Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #19511)
For some reason the newly introduced CI test for sctp causes issues. It is unknown why this seems to work when testing, but doesnt work once it was merged. The test has been put into its own file, with skips on error if the setup fails.. This will need to be merged to test if this works. Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#19511)
For some reason when I tried this before it worked. So retrying this again to see if it still works.
Not sure why it decided to fail once merged yet.
Checklist