Fix coverity 1516093 tainted scalar #19519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|uclen| is created from three byte values, so this seems a bit redundant, but if it makes coverity happy
tmshort
added
branch: master
|
Second attempt at fixing this issue. |
t8m
approved these changes
Oct 27, 2022
t8m
approved these changes
Oct 27, 2022
t8m
removed
the
approval: otc review pending
hlandau
approved these changes
Oct 27, 2022
hlandau
added
approval: done
|
Is the CIFuzz cancel (really a crash?) relevant? |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
|
Merged to master branch. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 2, 2022
|uclen| is created from three byte values, so this seems a bit redundant, but if it makes coverity happy Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #19519)
|
Thank you! |
|
Looks as though Coverity is clean now. |
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
|uclen| is created from three byte values, so this seems a bit redundant, but if it makes coverity happy Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#19519)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
|uclen| is created from three byte values, so this seems a bit redundant, but if it makes coverity happy
Checklist