Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverity 1516624: Fix overrun memory access. #19576

Closed
wants to merge 1 commit into from

Conversation

paulidale
Copy link
Contributor

Not possible to hit but good to address.

  • documentation is added or updated
  • tests are added or updated

Not possible to hit but good to address.
@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 labels Nov 2, 2022
@paulidale paulidale self-assigned this Nov 2, 2022
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Nov 2, 2022
@hlandau hlandau added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Nov 2, 2022
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@t8m t8m added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Nov 3, 2022
@t8m
Copy link
Member

t8m commented Nov 3, 2022

Merged to master, 3.1, and 3.0 branches. Thank you.

@t8m t8m closed this Nov 3, 2022
openssl-machine pushed a commit that referenced this pull request Nov 3, 2022
Not possible to hit but good to address.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19576)

(cherry picked from commit ce0a7ca)
openssl-machine pushed a commit that referenced this pull request Nov 3, 2022
Not possible to hit but good to address.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19576)
openssl-machine pushed a commit that referenced this pull request Nov 3, 2022
Not possible to hit but good to address.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19576)

(cherry picked from commit ce0a7ca)
@paulidale paulidale deleted the punycode-test branch November 3, 2022 10:07
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
Not possible to hit but good to address.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#19576)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants