crypto/sha/asm/sha512-ia64.pl: When checking assembler file names, ignore case #19604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nore case The use case is that uppercase .ASM extension may be used on some platforms, and we were only testing for the lowercase extension.
levitte
added
approval: otc review pending
beldmit
approved these changes
Nov 4, 2022
beldmit
removed
the
approval: otc review pending
Yeah well, GitHub Actions won't verify that, and VMS builds are only done on push (because much too slow for PRs), so you'll have to take my word for it that my manual builds compile that assembler file fine with this change. |
mattcaswell
approved these changes
Nov 4, 2022
|
Is this causing a CI failure somewhere? I assume with VMS. If so agree urgent. |
mattcaswell
added
approval: ready to merge
It hasn't showed up in our builds yet... I had a manual build ongoing that I only updated with #19598 and remade, and failure to run this perlasm script came withing minutes. Because our VMS workers are commanded to rebuild from a clean directory, it will take a while before those builds get to the same spot. |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 4, 2022
…nore case The use case is that uppercase .ASM extension may be used on some platforms, and we were only testing for the lowercase extension. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #19604) (cherry picked from commit 119b7b5)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 4, 2022
…nore case The use case is that uppercase .ASM extension may be used on some platforms, and we were only testing for the lowercase extension. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #19604)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 4, 2022
…nore case The use case is that uppercase .ASM extension may be used on some platforms, and we were only testing for the lowercase extension. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #19604) (cherry picked from commit 119b7b5)
|
And hopefully, there aren't more nits like this. Buildbot will tell... |
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
…nore case The use case is that uppercase .ASM extension may be used on some platforms, and we were only testing for the lowercase extension. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from openssl#19604)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use case is that uppercase .ASM extension may be used on some platforms,
and we were only testing for the lowercase extension.