Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to link explicitly with libpthread on Solaris #19611

Closed
wants to merge 2 commits into from

Conversation

darrenmoffat
Copy link
Contributor

CLA: trivial

Reviewed-by: Zdenek.Kotal@oracle.com
Reviewed-by: Ali.Bahrami@oracle.com

Fixes #19607

Checklist

CLA: trivial

Reviewed-by: Zdenek.Kotal@oracle.com
Reviewed-by: Ali.Bahrami@oracle.com
t8m
t8m previously approved these changes Nov 4, 2022
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is mostly removals, it seems acceptable to me with CLA:trivial.

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: feature The issue/pr requests/adds a feature labels Nov 4, 2022
Configurations/10-main.conf Outdated Show resolved Hide resolved
@t8m t8m removed the approval: review pending This pull request needs review by a committer label Nov 7, 2022
@t8m t8m dismissed their stale review November 7, 2022 08:32

Premature

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Nov 8, 2022
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmshort
Copy link
Contributor

tmshort commented Nov 8, 2022

This is primarily deletes (with one edit). I don't know if it qualifies for CLA:trivial, but I'd be OK with it.

@t8m t8m added cla: trivial One of the commits is marked as 'CLA: trivial' approval: otc review pending This pull request needs review by an OTC member and removed hold: cla required The contributor needs to submit a license agreement labels Nov 8, 2022
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with CLA: trivial

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: otc review pending This pull request needs review by an OTC member labels Nov 8, 2022
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@mattcaswell mattcaswell added the tests: exempted The PR is exempt from requirements for testing label Nov 15, 2022
@t8m
Copy link
Member

t8m commented Dec 16, 2022

Merged to master branch. Thank you for your contribution.

@t8m t8m closed this Dec 16, 2022
openssl-machine pushed a commit that referenced this pull request Dec 16, 2022
CLA: trivial

Reviewed-by: Zdenek.Kotal@oracle.com
Reviewed-by: Ali.Bahrami@oracle.com
Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19611)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial' tests: exempted The PR is exempt from requirements for testing triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No need to link explicitly with libpthread on Solaris
5 participants