Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIPS 140-3 fix ups #19631

Closed
wants to merge 4 commits into from
Closed

FIPS 140-3 fix ups #19631

wants to merge 4 commits into from

Conversation

paulidale
Copy link
Contributor

The OTC wants smarter tests that allow forward and backward transport of any FIPS provider.

@paulidale paulidale added branch: master Merge to master branch branch: 3.1 Merge to openssl-3.1 labels Nov 9, 2022
@paulidale paulidale self-assigned this Nov 9, 2022
@slontis
Copy link
Member

slontis commented Nov 9, 2022

Any possibility that the buildbot for mac can be removed?

@slontis
Copy link
Member

slontis commented Nov 9, 2022

Has it been checked with the lab that this is allowed for FIPS 140-3?

@paulidale
Copy link
Contributor Author

SP 800-131Ar2 is pretty clear that decryption is permitted for legacy applications:

Algorithm Status
Three-key TDEA Encryption Deprecated through 2023
Disallowed after 2023
Three-key TDEA Decryption Legacy use

I did send a note to the lab but haven't heard back yet.

@paulidale paulidale marked this pull request as ready for review November 9, 2022 06:06
@paulidale paulidale added the approval: review pending This pull request needs review by a committer label Nov 9, 2022
@t8m t8m added the triaged: feature The issue/pr requests/adds a feature label Nov 9, 2022
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Nov 9, 2022
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@t8m
Copy link
Member

t8m commented Nov 10, 2022

Merged to master and 3.1 branches. Thank you.

@t8m t8m closed this Nov 10, 2022
openssl-machine pushed a commit that referenced this pull request Nov 10, 2022
This reverts commit fc0bb34 and changes
how 3DES is advertised.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19631)

(cherry picked from commit a0ea8ac)
openssl-machine pushed a commit that referenced this pull request Nov 10, 2022
This reverts commit c511953.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19631)

(cherry picked from commit c69cf38)
openssl-machine pushed a commit that referenced this pull request Nov 10, 2022
This reverts commit 464c101.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19631)

(cherry picked from commit ccc860a)
openssl-machine pushed a commit that referenced this pull request Nov 10, 2022
This reverts commit 5db2b4a.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19631)

(cherry picked from commit 75fcf10)
openssl-machine pushed a commit that referenced this pull request Nov 10, 2022
This reverts commit fc0bb34 and changes
how 3DES is advertised.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19631)
openssl-machine pushed a commit that referenced this pull request Nov 10, 2022
This reverts commit c511953.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19631)
openssl-machine pushed a commit that referenced this pull request Nov 10, 2022
This reverts commit 464c101.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19631)
openssl-machine pushed a commit that referenced this pull request Nov 10, 2022
This reverts commit 5db2b4a.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19631)
@paulidale paulidale deleted the 140-3-putback branch November 10, 2022 21:24
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
This reverts commit fc0bb34 and changes
how 3DES is advertised.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#19631)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
This reverts commit c511953.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#19631)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
This reverts commit 464c101.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#19631)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
This reverts commit 5db2b4a.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#19631)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 3.1 Merge to openssl-3.1 triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants