Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fips-label.yml: Fix the script after actions/github-script upgrade #19636

Closed
wants to merge 1 commit into from
Closed

fips-label.yml: Fix the script after actions/github-script upgrade #19636

wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Nov 9, 2022

The github rest calls are now under .rest.

The FIPS changed label is not being properly set now so marking urgent.

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug severity: urgent Fixes an urgent issue (exempt from 24h grace period) branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 labels Nov 9, 2022
@t8m
Copy link
Member Author

t8m commented Nov 9, 2022

See here for an example of failed job:
https://github.com/openssl/openssl/actions/runs/3426650142/jobs/5708706885

@mattcaswell mattcaswell removed the approval: otc review pending This pull request needs review by an OTC member label Nov 9, 2022
@mattcaswell
Copy link
Member

mattcaswell commented Nov 9, 2022 •
edited

Agree urgent

@t8m
Copy link
Member Author

t8m commented Nov 9, 2022

ping for second review

@paulidale
Copy link
Contributor

Agreed urgent. Three way merged.

@paulidale paulidale closed this Nov 9, 2022
openssl-machine pushed a commit that referenced this pull request Nov 9, 2022
@t8m
fips-label.yml: Fix the script after actions/github-script upgrade
ada6f05 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19636)
openssl-machine pushed a commit that referenced this pull request Nov 9, 2022
@t8m @paulidale
fips-label.yml: Fix the script after actions/github-script upgrade
e285a0b 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19636)

(cherry picked from commit ada6f05)
openssl-machine pushed a commit that referenced this pull request Nov 9, 2022
@t8m @paulidale
fips-label.yml: Fix the script after actions/github-script upgrade
3ede8f1 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19636)

(cherry picked from commit ada6f05)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@t8m @beldmit
fips-label.yml: Fix the script after actions/github-script upgrade
cbc87ff 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: review pending This pull request needs review by a committer branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 severity: urgent Fixes an urgent issue (exempt from 24h grace period) triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t8m @mattcaswell @paulidale