Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocsp: Add missing test if make_ocsp_response failed #19660

Closed
wants to merge 1 commit into from
Closed

ocsp: Add missing test if make_ocsp_response failed #19660

wants to merge 1 commit into from

Conversation

gilweis
Copy link
Contributor

@gilweis gilweis commented Nov 12, 2022 •
edited

Add missing test if make_ocsp_response failed.
This bug exist in openssl-1.* and openssl3.*
CLA: trivial

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Nov 12, 2022
@gilweis gilweis mentioned this pull request Nov 12, 2022
Closed
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Nov 13, 2022
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug cla: trivial One of the commits is marked as 'CLA: trivial' branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 labels Nov 14, 2022
t8m
t8m approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with CLA: trivial.

@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Nov 14, 2022
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Nov 14, 2022
beldmit
beldmit approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agree with trivial

@beldmit beldmit added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Nov 14, 2022
@t8m t8m added the tests: exempted The PR is exempt from requirements for testing label Nov 14, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Nov 15, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m t8m removed the branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch label Nov 15, 2022
@t8m
Copy link
Member

t8m commented Nov 15, 2022

Merged to master, 3.1, and 3.0 branches. 1.1.1 is security-fix only.

Thank you for your contribution.

@t8m t8m closed this Nov 15, 2022
openssl-machine pushed a commit that referenced this pull request Nov 15, 2022
@gilweis @t8m
apps/ocsp.c: Add missing test if make_ocsp_response failed
d163bd0 
CLA: trivial

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19660)

(cherry picked from commit 93e1271)
openssl-machine pushed a commit that referenced this pull request Nov 15, 2022
@gilweis @t8m
apps/ocsp.c: Add missing test if make_ocsp_response failed
93e1271 
CLA: trivial

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19660)
openssl-machine pushed a commit that referenced this pull request Nov 15, 2022
@gilweis @t8m
apps/ocsp.c: Add missing test if make_ocsp_response failed
2f3f0b0 
CLA: trivial

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19660)

(cherry picked from commit 93e1271)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@gilweis @beldmit
apps/ocsp.c: Add missing test if make_ocsp_response failed
bb5b7e4 
CLA: trivial

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#19660)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@beldmit beldmit beldmit approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 cla: trivial One of the commits is marked as 'CLA: trivial' severity: fips change The pull request changes FIPS provider sources tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gilweis @openssl-machine @t8m @beldmit