Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping tests in evp_test leaks memory #1968

Closed
wants to merge 1 commit into from

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Nov 20, 2016

Checklist
  • documentation is added or updated
  • tests are added or updated
  • CLA is signed
Description of change

When configured with "no-mdc2 enable-crypto-mdebug" the evp_test
will leak memory due to skipped tests, and error out.

Also fix a skip condition

When configured with "no-mdc2 enable-crypto-mdebug" the evp_test
will leak memory due to skipped tests, and error out.

Also fix a skip condition
@richsalz
Copy link
Contributor

ping @levitte this is the same as you approved in #1946

@richsalz richsalz self-assigned this Nov 20, 2016
@richsalz richsalz added branch: master Merge to master branch reviewed labels Nov 20, 2016
Copy link
Member

@levitte levitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

@levitte levitte added the approval: done This pull request has the required number of approvals label Nov 21, 2016
levitte pushed a commit that referenced this pull request Nov 21, 2016
When configured with "no-mdc2 enable-crypto-mdebug" the evp_test
will leak memory due to skipped tests, and error out.

Also fix a skip condition

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #1968)
@richsalz
Copy link
Contributor

commit 024d681 pushed. thanks!

@richsalz richsalz closed this Nov 21, 2016
@tmshort tmshort deleted the master-evp-test-mem-leak branch April 28, 2017 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants