test/recipes/80-test_cms.t: Fix the "CAdES ko" test #19731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test had commands that assumes that runner_loop() is used to perform the tests. These tests still run fine because Unix accepts braces in file names, but other operating systems might not.
levitte
added
approval: otc review pending
|
Made urgent because this test fails on VMS. All other tests are |
beldmit
removed
the
approval: otc review pending
|
Agree urgent |
mattcaswell
reviewed
Nov 22, 2022
| @@ -800,6 +800,7 @@ subtest "CAdES ko tests\n" => sub { | |||
| SKIP: { | |||
| my $skip_reason = check_availability($$_[0]); | |||
| skip $skip_reason, 1 if $skip_reason; | |||
| 1 while unlink "cades-ko.txt"; | |||
There was a problem hiding this comment.
Why is a loop required here?
Also, doesn't this leave cades-ko.txt undeleted on the final loop? Or, maybe that doesn't matter...
There was a problem hiding this comment.
It's required on VMS, where files may exist in multiple generations (so cades-ko.txt;1, cades-ko.txt;2, ...)
There was a problem hiding this comment.
Regarding deleting all but for the final loop, you're right about that. However, the array we use has only one element. The function runner_loop handles that better, but isn't quite suitable for this particular test because of the second negative test. I've thoughts on reworking runner_loop, but that's overkill for this fix.
t8m
added
approval: ready to merge
|
Merged to 3.1 and master branches. Thank you. |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 22, 2022
This test had commands that assumes that runner_loop() is used to perform the tests. These tests still run fine because Unix accepts braces in file names, but other operating systems might not. Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #19731)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 22, 2022
This test had commands that assumes that runner_loop() is used to perform the tests. These tests still run fine because Unix accepts braces in file names, but other operating systems might not. Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #19731) (cherry picked from commit 20d3731)
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
This test had commands that assumes that runner_loop() is used to perform the tests. These tests still run fine because Unix accepts braces in file names, but other operating systems might not. Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#19731) (cherry picked from commit 20d3731)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test had commands that assumes that runner_loop() is used to perform
the tests. These tests still run fine because Unix accepts braces in file
names, but other operating systems might not.