Improve the QUIC_RSTREAM implementation #19794
Conversation
t8m
added
branch: master
|
This is a draft as tests need to be added to cover the new API calls. |
t8m
added
approval: review pending
hlandau
removed
the
approval: otc review pending
|
@hlandau still OK? |
hlandau
added
approval: done
|
This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago |
|
Needs rebase and second approval |
Add API calls to avoid copying data when reading These are ossl_quic_rstream_get_record() and ossl_quic_rstream_release_record(). Add side storage for the stream frame data. When there are too many packets referenced by the receiving stream the function ossl_quic_rstream_move_to_rbuf() can be called to move the data to a ring buffer.
t8m
force-pushed
the
rstream-improvements
branch
from
9604b31
to
d57773c
Compare
|
Rebased. @hlandau please reconfirm. Ping @openssl/committers for second approval. The improvements should be used by the code, but that is a separate work task. |
The reason is to avoid unnecessary allocations/deallocations. |
|
Hmmm, feels a bit like premature optimisation. The downside will be extra copies won't it? |
Which extra copies? The ring buffer is used only when we are asked to deallocate the packets. We primarily use a linked list of received frames (with pointers to the packets holding the frames to deallocate later). The ring buffer is used only when the ossl_quic_rstream_move_to_rbuf() is called. That would be called by quic channel if there are too many packets being in process. Detecting that condition is something that still needs to be added to the quic channel implementation. |
|
fixup pushed addressing @mattcaswell 's comments. @hlandau @mattcaswell please approve |
|
CI failure looks relevant. |
Reported by Marc Schönefeld.
Should be fixed now. |
|
@mattcaswell @hlandau please re-approve |
hlandau
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to master branch. Thank you for the reviews. |
Add API calls to avoid copying data when reading These are ossl_quic_rstream_get_record() and ossl_quic_rstream_release_record(). Add side storage for the stream frame data. When there are too many packets referenced by the receiving stream the function ossl_quic_rstream_move_to_rbuf() can be called to move the data to a ring buffer. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from #19794)
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from #19794)
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from #19794)
Reported by Marc Schönefeld. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from #19794)
Add API calls to avoid copying data when reading
These are ossl_quic_rstream_get_record() and
ossl_quic_rstream_release_record().
Add side storage for the stream frame data.
When there are too many packets referenced by the
receiving stream the function ossl_quic_rstream_move_to_rbuf() can be called to move the data to a ring buffer.
Checklist