Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the code used to detect aarch64 capabilities when we don't have getauxval() #19833

Closed
wants to merge 1 commit into from
Closed

Fix the code used to detect aarch64 capabilities when we don't have getauxval() #19833

wants to merge 1 commit into from

Conversation

tom-cosgrove-arm
Copy link
Contributor

Fixes #19825.

@tom-cosgrove-arm
Fix the code used to detect aarch64 capabilities when we don't have g…
436dedd 
…etauxval()

In addition to a missing prototype there was also a missing closing brace '}'.

Fixes openssl#19825.
@tom-cosgrove-arm
Copy link
Contributor Author

I don't think the Run-checker fail at 90-test_memleak.t can be related to this change

mattcaswell
mattcaswell approved these changes Dec 5, 2022
View reviewed changes
crypto/armcap.c
@@ -354,6 +355,7 @@ void OPENSSL_cpuid_setup(void)
if (sigsetjmp(ill_jmp, 1) == 0) {
_armv8_sm3_probe();
OPENSSL_armcap_P |= ARMV8_SM3;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!! How did this ever work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was clearly never even tested :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(which I did do before this PR)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was clearly never even tested :(

Which is why we fortunately have alpha and beta pre-releases. As we cannot test on all environments that might be possibly supported by OpenSSL code base. 😁

The message to anyone who is using OpenSSL on platform that is not on the primary or secondary list - test the prereleases if you want the final release to support your platform.

@mattcaswell mattcaswell added branch: master Merge to master branch approval: review pending This pull request needs review by a committer branch: 3.1 Merge to openssl-3.1 labels Dec 5, 2022
@mattcaswell
Copy link
Member

Is this master/3.1 only? Or does it apply to 3.0 too?

@tom-cosgrove-arm
Copy link
Contributor Author

Fortunately this isn't in 3.0

@mattcaswell mattcaswell added the tests: exempted The PR is exempt from requirements for testing label Dec 5, 2022
@t8m t8m added the triaged: bug The issue/pr is/fixes a bug label Dec 5, 2022
@t8m t8m added this to the 3.1.0 milestone Dec 5, 2022
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Dec 5, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 6, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Dec 6, 2022

Merged to master and 3.1 branches. Thank you for your contribution.

@t8m t8m closed this Dec 6, 2022
openssl-machine pushed a commit that referenced this pull request Dec 6, 2022
@tom-cosgrove-arm @t8m
Fix the code used to detect aarch64 capabilities when we don't have g…
f97ddfc 
…etauxval()

In addition to a missing prototype there was also a missing closing brace '}'.

Fixes #19825.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19833)
openssl-machine pushed a commit that referenced this pull request Dec 6, 2022
@tom-cosgrove-arm @t8m
Fix the code used to detect aarch64 capabilities when we don't have g…
a6e5003 
…etauxval()

In addition to a missing prototype there was also a missing closing brace '}'.

Fixes #19825.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #19833)

(cherry picked from commit f97ddfc)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@tom-cosgrove-arm @beldmit
Fix the code used to detect aarch64 capabilities when we don't have g…
f35bfb0 
…etauxval()

In addition to a missing prototype there was also a missing closing brace '}'.

Fixes openssl#19825.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#19833)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
3.1.0
4 participants
@tom-cosgrove-arm @mattcaswell @openssl-machine @t8m