Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI fixes and workarounds for the recent CI failures #19860

Closed
wants to merge 3 commits into from
Closed

CI fixes and workarounds for the recent CI failures #19860

wants to merge 3 commits into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Dec 8, 2022 •
edited

Fuzz checker CI: Use more generic include dir for fuzzer includes.

Cross compiles CI: Disable stringop-overflow warning on s390x and m68k

Run-checker merge CI: Replace no-shared with no-modules

@t8m t8m added branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug severity: urgent Fixes an urgent issue (exempt from 24h grace period) branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing labels Dec 8, 2022
@t8m
Cross compiles CI: Disable stringop-overflow warning on s390x and m68k
74a7f07 
These warnings trigger on false positives on these platforms
with recent compiler update.
levitte
levitte approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@levitte levitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok urgent

@t8m
Run-checker merge CI: Replace no-shared with no-modules
a835565 
ASAN otherwise fails to detect memleaks.
@t8m
Copy link
Member Author

t8m commented Dec 8, 2022

@levitte one more fix added, please reconfirm. The last failure should be fixed with #19841 - I wonder though, why it wasn't detected before.

@t8m t8m added approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member labels Dec 8, 2022
hlandau
hlandau approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@hlandau hlandau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree urgent.

@hlandau hlandau removed the approval: otc review pending This pull request needs review by an OTC member label Dec 8, 2022
@slontis
Copy link
Member

slontis commented Dec 8, 2022

There was still a failure here..

openssl-machine pushed a commit that referenced this pull request Dec 8, 2022
@t8m @paulidale
Fuzz checker CI: Use more generic include dir for fuzzer includes
aef6b82 
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19860)
openssl-machine pushed a commit that referenced this pull request Dec 8, 2022
@t8m @paulidale
Cross compiles CI: Disable stringop-overflow warning on s390x and m68k
8b63a30 
These warnings trigger on false positives on these platforms
with recent compiler update.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19860)
openssl-machine pushed a commit that referenced this pull request Dec 8, 2022
@t8m @paulidale
Run-checker merge CI: Replace no-shared with no-modules
d569654 
ASAN otherwise fails to detect memleaks.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19860)
@paulidale
Copy link
Contributor

Agreed, urgent and merged to all three branches. The remain CI failure should be a separate PR IMO.

@paulidale paulidale closed this Dec 8, 2022
openssl-machine pushed a commit that referenced this pull request Dec 8, 2022
@t8m @paulidale
Fuzz checker CI: Use more generic include dir for fuzzer includes
8face27 
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19860)

(cherry picked from commit aef6b82)
openssl-machine pushed a commit that referenced this pull request Dec 8, 2022
@t8m @paulidale
Cross compiles CI: Disable stringop-overflow warning on s390x and m68k
bc136fd 
These warnings trigger on false positives on these platforms
with recent compiler update.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19860)

(cherry picked from commit 8b63a30)
openssl-machine pushed a commit that referenced this pull request Dec 8, 2022
@t8m @paulidale
Run-checker merge CI: Replace no-shared with no-modules
39fcc35 
ASAN otherwise fails to detect memleaks.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19860)

(cherry picked from commit d569654)
openssl-machine pushed a commit that referenced this pull request Dec 8, 2022
@t8m @paulidale
Fuzz checker CI: Use more generic include dir for fuzzer includes
a09f6a1 
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19860)

(cherry picked from commit aef6b82)
openssl-machine pushed a commit that referenced this pull request Dec 8, 2022
@t8m @paulidale
Cross compiles CI: Disable stringop-overflow warning on s390x and m68k
b23521c 
These warnings trigger on false positives on these platforms
with recent compiler update.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19860)

(cherry picked from commit 8b63a30)
openssl-machine pushed a commit that referenced this pull request Dec 8, 2022
@t8m @paulidale
Run-checker merge CI: Replace no-shared with no-modules
3956fc9 
ASAN otherwise fails to detect memleaks.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19860)

(cherry picked from commit d569654)
@t8m t8m added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: review pending This pull request needs review by a committer labels Dec 9, 2022
t8m added a commit to t8m/openssl that referenced this pull request Dec 9, 2022
@t8m
Fix typo in Run-checker merge CI fix
175e606 
Followup to openssl#19860
matheushw pushed a commit to matheushw/openssl that referenced this pull request Dec 11, 2022
@t8m
CLA: trivial
770efb7 
Run-checker merge CI: Replace no-shared with no-modules

ASAN otherwise fails to detect memleaks.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19860)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@t8m @beldmit
Fuzz checker CI: Use more generic include dir for fuzzer includes
7008e44 
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19860)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@t8m @beldmit
Cross compiles CI: Disable stringop-overflow warning on s390x and m68k
45fdbc6 
These warnings trigger on false positives on these platforms
with recent compiler update.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19860)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@t8m @beldmit
Run-checker merge CI: Replace no-shared with no-modules
ac82109 
ASAN otherwise fails to detect memleaks.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19860)
@dongbeiouba dongbeiouba mentioned this pull request Jun 28, 2023
Merged
5 tasks
@FullyRobert FullyRobert mentioned this pull request Jun 28, 2023
Closed
5 tasks
dongbeiouba added a commit to Tongsuo-Project/Tongsuo that referenced this pull request Jun 30, 2023
@dongbeiouba
Fuzz checker CI: Use more generic include dir for fuzzer includes
72a506d 
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#19860)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@hlandau hlandau hlandau approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@t8m @slontis @paulidale @levitte @hlandau