Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverity: fix 272011 resource leak #19900

Closed
wants to merge 1 commit into from
Closed

Coverity: fix 272011 resource leak #19900

wants to merge 1 commit into from

Conversation

paulidale
Copy link
Contributor

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 labels Dec 13, 2022
@paulidale paulidale self-assigned this Dec 13, 2022
@paulidale paulidale mentioned this pull request Dec 13, 2022
Closed
11 tasks
romen
romen approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@romen romen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, on the assumption all tests pass, and excluding the unrelated pyca-test failure.

@romen romen removed the approval: otc review pending This pull request needs review by an OTC member label Dec 13, 2022
@slontis slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Dec 13, 2022
@t8m t8m added the tests: exempted The PR is exempt from requirements for testing label Dec 14, 2022
@t8m t8m added this to the 3.1.0 milestone Dec 14, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 15, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor Author

Merged, thanks.

@paulidale paulidale closed this Dec 15, 2022
openssl-machine pushed a commit that referenced this pull request Dec 15, 2022
@paulidale
Coverity: fix 272011 resource leak
a167e04 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #19900)
openssl-machine pushed a commit that referenced this pull request Dec 15, 2022
@paulidale
Coverity: fix 272011 resource leak
0756e7a 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #19900)

(cherry picked from commit a167e04)
openssl-machine pushed a commit that referenced this pull request Dec 15, 2022
@paulidale
Coverity: fix 272011 resource leak
878b00a 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #19900)

(cherry picked from commit a167e04)
@paulidale paulidale deleted the coverity-272011 branch March 30, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romen romen romen approved these changes

@t8m t8m t8m approved these changes

@slontis slontis slontis approved these changes

Assignees

@paulidale paulidale

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@paulidale @openssl-machine @romen @t8m @slontis