Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pyca-cryptography submodule to fix CI #19926

Closed
wants to merge 1 commit into from
Closed

Update pyca-cryptography submodule to fix CI #19926

wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Dec 16, 2022

This is needed to fix CI on master branch. Proposing as urgent fix.

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: exempted The PR is exempt from requirements for testing labels Dec 16, 2022
beldmit
beldmit approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests passed. agree urgent.

@beldmit beldmit removed the approval: otc review pending This pull request needs review by an OTC member label Dec 16, 2022
@t8m t8m requested review from hlandau and levitte December 16, 2022 14:22
@levitte levitte added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: review pending This pull request needs review by a committer labels Dec 16, 2022
openssl-machine pushed a commit that referenced this pull request Dec 16, 2022
@t8m
Update pyca-cryptography submodule to fix CI
a8e7bc7 
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #19926)
@t8m
Copy link
Member Author

t8m commented Dec 16, 2022

Merged. Thank you for the reviews.

@t8m t8m closed this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@beldmit beldmit beldmit approved these changes

@hlandau hlandau Awaiting requested review from hlandau

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t8m @levitte @beldmit