Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the padlock engine (1.1.1) #20147

Closed
wants to merge 1 commit into from
Closed

Fix the padlock engine (1.1.1) #20147

wants to merge 1 commit into from

Conversation

bernd-edlinger
Copy link
Member

... after it was broken for almost 5 years,
since the first 1.1.1 release.
Note: The last working version was 1.1.0l release.

Fixes #20073

backport of #20146 to 1.1.1 branch.

@bernd-edlinger
Fix the padlock engine
8a2b35b 
... after it was broken for almost 5 years,
since the first 1.1.1 release.
Note: The last working version was 1.1.0l release.

Fixes openssl#20073
@bernd-edlinger bernd-edlinger added the branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch label Jan 26, 2023
@ValdikSS
Copy link
Contributor

It should be noted that this patch fixes Padlock when compiled with -DOPENSSL_AES_CONST_TIME. There were no issues without this define after commit 7331e7e.

@t8m t8m added approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug tests: exempted The PR is exempt from requirements for testing labels Jan 27, 2023
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Jan 27, 2023
@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 61 days ago

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 92 days ago

@ValdikSS
Copy link
Contributor

Hi, any updates? The fix seem to be rather trivial.

@kaduk kaduk added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 18, 2023
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@bernd-edlinger
Copy link
Member Author

CI failure appears unrelated

@bernd-edlinger bernd-edlinger added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels May 21, 2023
openssl-machine pushed a commit that referenced this pull request May 21, 2023
@bernd-edlinger
Fix the padlock engine
e94b438 
... after it was broken for almost 5 years,
since the first 1.1.1 release.
Note: The last working version was 1.1.0l release.

Fixes #20073

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
(Merged from #20147)
@bernd-edlinger
Copy link
Member Author

Merged to 1.1.1 as e94b438. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaduk kaduk kaduk approved these changes

@t8m t8m t8m approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bernd-edlinger @ValdikSS @openssl-machine @kaduk @t8m