OSSL_CMP_certConf_cb(): fix regression on checking newly enrolled cert
#20160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add corresponding tests and to this end update credentials
DDvO
added
branch: master
t8m
approved these changes
Jan 28, 2023
t8m
removed
the
approval: otc review pending
paulidale
approved these changes
Feb 5, 2023
paulidale
removed
the
approval: review pending
DDvO
added
the
approval: done
|
24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually. |
openssl-machine
pushed a commit
that referenced
this pull request
Feb 13, 2023
Also add corresponding tests and to this end update credentials Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from #20160)
|
Merged to master, 3.0, and 3.1 - thanks @t8m and @paulidale for the approvals. |
hardik05
pushed a commit
to hardik05/openssl
that referenced
this pull request
Feb 22, 2023
Also add corresponding tests and to this end update credentials Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from openssl#20160)
hardik05
pushed a commit
to hardik05/openssl
that referenced
this pull request
Feb 22, 2023
Also add corresponding tests and to this end update credentials Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from openssl#20160)
hardik05
pushed a commit
to hardik05/openssl
that referenced
this pull request
Feb 22, 2023
Also add corresponding tests and to this end update credentials Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from openssl#20160)
DDvO
added a commit
to mpeylo/cmpossl
that referenced
this pull request
Jun 29, 2023
…t - complete earlier inclusion Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from openssl#20160)
DDvO
added a commit
to siemens/gencmpclient
that referenced
this pull request
Jun 29, 2023
…lled cert - complete earlier inclusion Also add corresponding tests and to this end update credentials Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from openssl/openssl#20160)
DDvO
added a commit
to siemens/gencmpclient
that referenced
this pull request
Jul 13, 2023
…lled cert - complete earlier inclusion Also add corresponding tests and to this end update credentials Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from openssl/openssl#20160)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported that a regression had been incurred by #14128:
the default certificate confirmation callback no more verified the newly enrolled cert,
while this still should be done if a trust store has been provided to this function.
This issue should have captured to some extent by an existing test case,
but the expected failure happend for not the right reason:
it was due to a cert file not being present rather than the intended cert being expired.
While fixing this, also I added corresponding tests and to this end had to update the test server credentials
and remove a workaround in the test configuration (which so far simply had disabled cert expiration checks).
Also made the doc of the callback function and of the related
-out_trustedCLI option a little more precise.Checklist