Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add punycode tests #20177

Closed
wants to merge 1 commit into from
Closed

Add punycode tests #20177

wants to merge 1 commit into from

Conversation

slontis
Copy link
Member

@slontis slontis commented Jan 31, 2023

The unused and untested internal function ossl_a2ucompare() has been removed.

Checklist
  • documentation is added or updated
  • tests are added or updated

@slontis
Add punycode tests
e56a35e 
The unused and untested internal function ossl_a2ucompare() has been
removed.
@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer tests: present The PR has suitable tests present labels Jan 31, 2023
beldmit
beldmit approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jan 31, 2023
@t8m t8m added the triaged: refactor The issue/pr requests/implements refactoring label Jan 31, 2023
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@t8m
Copy link
Member

t8m commented Feb 8, 2023

Merged to master branch. Thank you for your contribution.

@t8m t8m closed this Feb 8, 2023
openssl-machine pushed a commit that referenced this pull request Feb 8, 2023
@slontis @t8m
Add more punycode tests and remove ossl_a2ucompare()
23e6556 
The unused and untested internal function ossl_a2ucompare() has been
removed.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #20177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beldmit beldmit beldmit approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch tests: present The PR has suitable tests present triaged: refactor The issue/pr requests/implements refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@slontis @openssl-machine @t8m @beldmit @paulidale