Add Tests for RSA_sign_ASN1_OCTET_STRING & RSA_verify_ASN1_OCTET_STRING #20220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Internally RSA_sign_ASN1_OCTET_STRING() is used with RSA signing only when the digest is MDC2, and RSA_verify_ASN1_OCTET_STRING() is unused.
slontis
added
branch: master
paulidale
approved these changes
Feb 6, 2023
paulidale
removed
the
approval: otc review pending
t8m
approved these changes
Feb 6, 2023
t8m
added
approval: done
|
24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually. |
|
Merged to master branch. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Feb 8, 2023
Note: Internally RSA_sign_ASN1_OCTET_STRING() is used with RSA signing only when the digest is MDC2, and RSA_verify_ASN1_OCTET_STRING() is unused. Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #20220)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Internally RSA_sign_ASN1_OCTET_STRING() is used with RSA signing only when the digest is MDC2,
and RSA_verify_ASN1_OCTET_STRING() is unused.
Checklist