New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test framework: Add the possibility to have a test specific data dir #2027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This data directory is formed automatically by taking the recipe name and changing '.t' to '_data'. Files in there can be reached with the new function data_file()
levitte
force-pushed
the
test-source-data
branch
from
December 8, 2016 13:20
40fecab
to
f4c200d
Compare
richsalz
approved these changes
Dec 9, 2016
FdaSilvaYY
reviewed
Dec 9, 2016
@@ -50,13 +51,19 @@ This module I<depends> on the environment variables C<$TOP> or C<$SRCTOP> | |||
and C<$BLDTOP>. Without one of the combinations it refuses to work. | |||
See L</ENVIRONMENT> below. | |||
|
|||
With each test recipe, a parallell data directory with (almost) the same name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: parallell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I used the Swedish spelling. Will fix
Merged (with spelling fix) |
levitte
added a commit
that referenced
this pull request
Dec 9, 2016
This data directory is formed automatically by taking the recipe name and changing '.t' to '_data'. Files in there can be reached with the new function data_file() Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #2027)
kaduk
pushed a commit
to kaduk/openssl
that referenced
this pull request
Feb 28, 2017
This data directory is formed automatically by taking the recipe name and changing '.t' to '_data'. Files in there can be reached with the new function data_file() Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from openssl#2027) (cherry picked from commit 6c6a2ae)
levitte
added a commit
that referenced
this pull request
Mar 1, 2017
This data directory is formed automatically by taking the recipe name and changing '.t' to '_data'. Files in there can be reached with the new function data_file() (Merged from #2027) (cherry picked from commit 6c6a2ae) Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #2802)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
This data directory is formed automatically by taking the recipe name
and changing '.t' to '_data'. Files in there can be reached with the
new function data_file()