crypto/cmp: fix CertReqId to use in p10cr transactions
#20298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDvO
added
branch: master
paulidale
reviewed
Mar 15, 2023
paulidale
approved these changes
Mar 16, 2023
paulidale
removed
the
approval: otc review pending
|
Rebased to fix merge conflict. Ping @openssl/committers for 2nd review. |
tom-cosgrove-arm
added
approval: otc review pending
|
@paulidale could you please reconfirm? |
|
@paulidale Can you (or another @openss/otc) do an incremental review for the last commit? |
paulidale
approved these changes
Apr 16, 2023
paulidale
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
DDvO
added a commit
to siemens/openssl
that referenced
this pull request
Apr 18, 2023
Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from openssl#20298)
DDvO
added a commit
to siemens/openssl
that referenced
this pull request
Apr 18, 2023
Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from openssl#20298) (cherry picked from commit 25b18e6)
DDvO
added a commit
to siemens/openssl
that referenced
this pull request
Apr 18, 2023
Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from openssl#20298) (cherry picked from commit 25b18e6)
|
Merged to master, 3.0, and 3.1 - thanks @paulidale and @tom-cosgrove-arm for the reviews. |
This was referenced Apr 18, 2023
DDvO
added a commit
to mpeylo/cmpossl
that referenced
this pull request
Jan 16, 2024
Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from openssl#20298)
DDvO
added a commit
to mpeylo/cmpossl
that referenced
this pull request
Jan 17, 2024
Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from openssl#20298)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A colleague noticed that for
p10crtransactions both the CMP client does not use the CertReqId specified in RFC 4210.This is fixed here,
extending also the mock server in order to check for the right valuemoving the check for the right value from the mock server to the core server implementation and extending it as needed.
Checklist