VMS knows POSIX threads too! #20440
Closed
VMS knows POSIX threads too! #20440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include/internal/thread_arch.h didn't indicate this, now it does. This also invalidates ossl_crypto_mem_barrier(), which we isn't used anywhere. Reason for invalidation: it doesn't build with compilers that don't support the GNU extension __asm__.
levitte
added
branch: master
levitte
added
the
severity: urgent
|
I'm making this urgent, 'cause this is a very clear bug that make all testing fail |
github-actions
bot
added
the
severity: fips change
paulidale
reviewed
Mar 6, 2023
beldmit
reviewed
Mar 6, 2023
|
The VMS part looks good to me |
Because I don't know the intent with it. Will we ever use it? |
|
... but ok, I hear two voices saying that |
ossl_crypto_mem_barrier is now REMOVED, not just invalidated
|
The test_cmp_http failure on MacOS 11 / x86_64 isn't related to this PR. |
levitte
removed
the
approval: otc review pending
|
@beldmit are you ok with urgent? |
|
Yes, I agree with urgent |
levitte
removed
the
approval: review pending
|
Side note: I see a trend in forgetting to deal with the labels. Can we please stop this trend? |
levitte
added
the
approval: ready to merge
|
Merged ac21c17 VMS knows POSIX threads too! |
openssl-machine
pushed a commit
that referenced
this pull request
Mar 6, 2023
include/internal/thread_arch.h didn't indicate this, now it does. This also removes ossl_crypto_mem_barrier(), because we isn't used anywhere, and doesn't build with compilers that don't support the GNU extension __asm__. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #20440)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
`include/internal/thread_arch.h didn't indicate this, now it does.
This also invalidates
ossl_crypto_mem_barrier(), which we isn't usedanywhere. Reason for invalidation: it doesn't build with compilers
that don't support the GNU extension
__asm__.