Restore the ERR_FATAL_ERROR() macro #2049
Conversation
Commit 0cd0a82 removed this macro along with many unused function and reason codes; ERR_FATAL_ERROR() was not used in the tree, but did have external consumers. Add it back to restore the API compatibility and avoid breaking applications for no internal benefit.
|
-1 for 1.1.0, +1 for master |
|
@dot-asm could you say a bit about why? It unfortunately does not seem obvious to me. |
I'm opposed to any public header modifications between letter releases. Note that this is not a veto, just an opinion. |
|
Thanks for the reminder; I do remember this coming up previously, now. |
|
We don't all agree when it comes to error codes and messages. Just sayin' |
I would go further. I am positively against a blanket ban policy on no header file changes. I do not believe that is correct - and is even a detrimental step. I see no problem with this change going into 1.1.0. The Appveyor failure seem unrelated to this. Something to do with the UI stuff? |
|
@richsalz will you merge? |
|
I'll have a look at the appveyor failures later today |
mattcaswell
added
the
approval: done
Commit 0cd0a82 removed this macro along with many unused function and reason codes; ERR_FATAL_ERROR() was not used in the tree, but did have external consumers. Add it back to restore the API compatibility and avoid breaking applications for no internal benefit. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #2049)
Commit 0cd0a82 removed this macro along with many unused function and reason codes; ERR_FATAL_ERROR() was not used in the tree, but did have external consumers. Add it back to restore the API compatibility and avoid breaking applications for no internal benefit. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #2049) (cherry picked from commit 036ba50)
Checklist
Description of change
Commit 0cd0a82 removed this macro
along with many unused function and reason codes; ERR_FATAL_ERROR()
was not used in the tree, but did have external consumers.
Add it back to restore the API compatibility and avoid breaking
applications for no internal benefit.
We could wrap this in an OPENSSL_API_COMPAT check if we don't want to support it indefinitely.