Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation to reflect new Windows on Arm configurations. #20525

Closed
wants to merge 3 commits into from
Closed

Update documentation to reflect new Windows on Arm configurations. #20525

wants to merge 3 commits into from

Conversation

everton1984
Copy link
Contributor

Two new configuration targets were added for Windows on Arm but the documentation is not reflecting it. This patch hopefully fixes this.

t8m
t8m requested changes Mar 16, 2023
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the long lines.

@t8m t8m added branch: master Merge to master branch triaged: documentation The issue/pr deals with documentation (errors) tests: exempted The PR is exempt from requirements for testing labels Mar 16, 2023
@everton1984
Copy link
Contributor Author

Please split the long lines.

Just changed it, is it better?

t8m
t8m reviewed Mar 16, 2023
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the one minor typo

NOTES-WINDOWS.md Outdated Show resolved Hide resolved
@t8m t8m added the approval: review pending This pull request needs review by a committer label Mar 16, 2023
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Mar 16, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Mar 17, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Mar 20, 2023

Merged to master branch. Thank you for your contribution.

@t8m t8m closed this Mar 20, 2023
openssl-machine pushed a commit that referenced this pull request Mar 20, 2023
@everton1984 @t8m
Update documentation to reflect new Windows on Arm configurations
e9460bb 
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #20525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@everton1984 @openssl-machine @t8m @tom-cosgrove-arm